[PATCH] D82387: [flang] add RTBuilder

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 12:54:01 PDT 2020


DavidTruby added a comment.

Is there a reason to use `float _Complex` here at all? The C++ standard (29.5.4 of C++17) guarantees that `std::complex<float>` and `float _Complex` are layout compatible and can be reinterpret_casted to each other so even if these functions are intended to be callable from C/interoperable with _Complex in C code, it'd be better to use std::complex<float> on the C++ side.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82387/new/

https://reviews.llvm.org/D82387





More information about the llvm-commits mailing list