[PATCH] D82713: Improve stack object printing.

Madhur Amilkanthwar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 2 01:01:54 PDT 2020


madhur13490 marked an inline comment as done.
madhur13490 added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineFrameInfo.cpp:250
     }
-    OS << "\n";
+    OS << "Split Slot: "
+       << (static_cast<bool>(SO.isSpillSlot) == true ? "Yes" : "No") << "\n";
----------------
arsenm wrote:
> Switching from = to :, and capitalizing is inconsistent with the other fields
This inconsistency is already present. "Frame objects:" and "size=". What are you suggesting, = or :? And why?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82713/new/

https://reviews.llvm.org/D82713





More information about the llvm-commits mailing list