[PATCH] D82713: Improve stack object printing.

[Evandro Menezes via Phabricator via llvm-commits]

evandro added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineFrameInfo.cpp:240
     if (i < NumFixedObjects)
-      OS << ", fixed";
+      OS << ", fixed:";
     if (i < NumFixedObjects || SO.SPOffset != -1) {
----------------
s/fixed:/fixed/


================
Comment at: llvm/lib/CodeGen/MachineFrameInfo.cpp:250
     }
-    OS << "\n";
+    OS << "Split Slot: "
+       << (static_cast<bool>(SO.isSpillSlot) == true ? "Yes" : "No") << "\n";
----------------
madhur13490 wrote:
> arsenm wrote:
> > Switching from = to :, and capitalizing is inconsistent with the other fields
> This inconsistency is already present. "Frame objects:" and "size=". What are you suggesting, = or :? And why?
`Split` or `Spill`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82713/new/

https://reviews.llvm.org/D82713