[PATCH] D82713: Improve stack object printing.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 1 17:18:26 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineFrameInfo.cpp:218
 
+  OS << "Fixed Objects: " << static_cast<unsigned>(NumFixedObjects) << "\n";
+
----------------
Single quotes around \n


================
Comment at: llvm/lib/CodeGen/MachineFrameInfo.cpp:250
     }
-    OS << "\n";
+    OS << "Split Slot: "
+       << (static_cast<bool>(SO.isSpillSlot) == true ? "Yes" : "No") << "\n";
----------------
Switching from = to :, and capitalizing is inconsistent with the other fields


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82713/new/

https://reviews.llvm.org/D82713





More information about the llvm-commits mailing list