[PATCH] D80953: [AIX] asm output: use character literals in byte lists for strings

[Hubert Tong via llvm-commits]

On Tue, Jun 9, 2020 at 1:59 PM Hubert Tong via Phabricator <
reviews at reviews.llvm.org> wrote:

> hubert.reinterpretcast added inline comments.
>
>
> ================
> Comment at: llvm/lib/MC/MCAsmStreamer.cpp:905
> +    if (isPrint(C)) {
> +      OS << format(CharacterLiteralFormatString, static_cast<char>(C));
> +      return;
> ----------------
> May need to hedge against `-Werror,-Wformat-security` warning as seen
> recently on another commit.
>
Verified that using Clang trunk and Clang 10 on the file does not trigger a
`-Werror,-Wformat-security` message.


>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D80953/new/
>
> https://reviews.llvm.org/D80953
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200627/a935d613/attachment-0001.html>