<div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 9, 2020 at 1:59 PM Hubert Tong via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">hubert.reinterpretcast added inline comments.<br>
<br>
<br>
================<br>
Comment at: llvm/lib/MC/MCAsmStreamer.cpp:905<br>
+    if (isPrint(C)) {<br>
+      OS << format(CharacterLiteralFormatString, static_cast<char>(C));<br>
+      return;<br>
----------------<br>
May need to hedge against `-Werror,-Wformat-security` warning as seen recently on another commit.<br></blockquote><div>Verified that using Clang trunk and Clang 10 on the file does not trigger a 
`-Werror,-Wformat-security` message.

</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D80953/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D80953/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D80953" rel="noreferrer" target="_blank">https://reviews.llvm.org/D80953</a><br>
<br>
<br>
<br>
</blockquote></div></div>