[PATCH] D82440: [Power10] Implement Vector Shift Double Bit Immediate Builtins in LLVM/Clang

[Biplob Mishra via Phabricator via llvm-commits]

biplmish added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:581
+   def VSRDBI :
+     VNForm_VTAB5_SD3<22, 0, (outs vrrc:$VRT), (ins vrrc:$VRA, vrrc:$VRB, u3imm:$SH),
+                      "vsrdbi $VRT, $VRA, $VRB, $SH", IIC_VecGeneral,
----------------
amyk wrote:
> The second value (`ps`) should not be 0. It should be 1, right?
Thats right. Thanks for pointing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82440/new/

https://reviews.llvm.org/D82440