[PATCH] D82408: [NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp

Zarko Todorovski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 24 08:36:55 PDT 2020


ZarkoCA marked 4 inline comments as done.
ZarkoCA added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7204
+//   AIX ABI Stack Frame Layout:
+//            +--------------------------------------------+
+//   SP +---> | Back chain                                 |
----------------
sfertile wrote:
> 
> Can we add something over on the right hand side to show which of these make up the linkage area? Something like:
> 
> ```
>  --|
>    |
>    |
>    |
>    | Linkage Area
>    |
>    |
>    |
>    |
>   --
> ```
Good suggestion, we should definitely have that. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82408/new/

https://reviews.llvm.org/D82408





More information about the llvm-commits mailing list