[PATCH] D82408: [NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp

[Sean Fertile via Phabricator via llvm-commits]

sfertile added a comment.

Looks good Zarko. I think we should either flip this over to show the stack growing down, or keep it as is but add `High Memory` at the bottom and `Low memory` at the top to show the stack grows downwards.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7204
+//   AIX ABI Stack Frame Layout:
+//            +--------------------------------------------+
+//   SP +---> | Back chain                                 |
----------------

Can we add something over on the right hand side to show which of these make up the linkage area? Something like:

```
 --|
   |
   |
   |
   | Linkage Area
   |
   |
   |
   |
  --
```


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7207
+//      |     +--------------------------------------------+
+//      |     | Saved Conditional Register                 |
+//      |     +--------------------------------------------+
----------------
Minor nit: Conditional --> Condition


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7235
+//      |     +--------------------------------------------+
+//      +---> | Back chain                                 |
+//            +--------------------------------------------+
----------------
minor nit:  `+---> ` should be `+--- ` . The first makes it look like the backchains point to each other as opposed to each backchain pointing ot the previous backchain.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82408/new/

https://reviews.llvm.org/D82408