[PATCH] D82408: [NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp

[Zarko Todorovski via Phabricator via llvm-commits]

ZarkoCA updated this revision to Diff 273035.
ZarkoCA marked an inline comment as done.
ZarkoCA added a comment.

Addressed Sean's comments:

Fixed typos and labelled linkage area in the stack frame.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82408/new/

https://reviews.llvm.org/D82408

Files:
  llvm/lib/Target/PowerPC/PPCISelLowering.cpp


Index: llvm/lib/Target/PowerPC/PPCISelLowering.cpp
===================================================================
--- llvm/lib/Target/PowerPC/PPCISelLowering.cpp
+++ llvm/lib/Target/PowerPC/PPCISelLowering.cpp
@@ -7200,6 +7200,45 @@
   llvm_unreachable("Only general purpose registers expected.");
 }
 
+//   AIX ABI Stack Frame Layout:
+//            +--------------------------------------------+
+//   SP +---> | Back chain                                 | ---+
+//      |     +--------------------------------------------+    |   
+//      |     | Saved Condition Register                   |    |
+//      |     +--------------------------------------------+    |
+//      |     | Saved Linkage Register                     |    |
+//      |     +--------------------------------------------+    | Linkage Area
+//      |     | Reserved for compilers                     |    |
+//      |     +--------------------------------------------+    |
+//      |     | Reserved for binders                       |    |
+//      |     +--------------------------------------------+    |
+//      |     | Saved TOC pointer                          | ---+
+//      |     +--------------------------------------------+
+//      |     | Parameter save area                        |
+//      |     +--------------------------------------------+
+//      |     | Alloca space                               |
+//      |     +--------------------------------------------+
+//      |     | Local variable space                       |
+//      |     +--------------------------------------------+
+//      |     | Float/int conversion temporary             |
+//      |     +--------------------------------------------+
+//      |     | Save area for AltiVec registers            |
+//      |     +--------------------------------------------+
+//      |     | AltiVec alignment padding                  |
+//      |     +--------------------------------------------+
+//      |     | Save area for VRSAVE register              |
+//      |     +--------------------------------------------+
+//      |     | Save area for General Purpose registers    |
+//      |     +--------------------------------------------+
+//      |     | Save area for Floating Point registers     |
+//      |     +--------------------------------------------+
+//      +---- | Back chain                                 |
+//            +--------------------------------------------+
+//
+//  Specifications:
+//  AIX 7.2 Assembler Language Reference
+//  Subroutine linkage convention
+
 SDValue PPCTargetLowering::LowerFormalArguments_AIX(
     SDValue Chain, CallingConv::ID CallConv, bool isVarArg,
     const SmallVectorImpl<ISD::InputArg> &Ins, const SDLoc &dl,
@@ -7425,6 +7464,8 @@
     const SmallVectorImpl<ISD::InputArg> &Ins, const SDLoc &dl,
     SelectionDAG &DAG, SmallVectorImpl<SDValue> &InVals,
     const CallBase *CB) const {
+  // See PPCTargetLowering::LowerFormalArguments_AIX() for a description of the
+  // AIX ABI stack frame layout.
 
   assert((CFlags.CallConv == CallingConv::C ||
           CFlags.CallConv == CallingConv::Cold ||


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82408.273035.patch
Type: text/x-patch
Size: 3137 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200624/c2ea5280/attachment.bin>