[PATCH] D82443: [ARM] Narrowing half-precision lowering to supported CCs

[Lucas Prates via Phabricator via llvm-commits]

pratlucas added a comment.

Hi @plotfi,

I believe simply limiting the calling conventions might be a bit tricky. At this point the method might get a calling convention id that does not reflect the one required for argument lowering (see `ARMTargetLowering::getEffectiveCallingConv` in `ARMISelLowering.cpp`).
One option to get around this would be to use that same method to determine the effective calling convention, but it might not be easy to check whether or not the function beeing handled is variadic.

Also, I did not expect to see a difference in the resulting parts' types between `getCopyToParts` and `ARMTargetLowering::splitValueIntoRegisterParts`, only in how the final type is achieved. I'm investigating this further to see what's missing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82443/new/

https://reviews.llvm.org/D82443