[PATCH] D82215: [AMDGPU] Avoid redundant mode register writes

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 24 03:12:37 PDT 2020


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM modulo Matt's comments and please consider cleaning it all up as mentioned earlier.



================
Comment at: llvm/lib/Target/AMDGPU/SIModeRegister.cpp:136
 
+  bool SetregInserted = false;
+
----------------
arsenm wrote:
> Probably should rename this, since this really should try to use S_ROUND_MODE/S_DENORM_MODE
`Changed` is the usual name for this kind of flag.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82215/new/

https://reviews.llvm.org/D82215





More information about the llvm-commits mailing list