[PATCH] D82365: [Power10] Implement Vector Insert Builtins in LLVM/Clang

[Amy Kwan via Phabricator via llvm-commits]

amyk added inline comments.


================
Comment at: clang/include/clang/Basic/BuiltinsPPC.def:309
 
+// P10 Vector insert built-ins
+BUILTIN(__builtin_altivec_vinsblx, "V16UcULLiULLi", "")
----------------
End with a period.


================
Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:429
+
+  //P10 Vector Insert
+  def int_ppc_altivec_vinsblx : GCCBuiltin<"__builtin_altivec_vinsblx">,
----------------
Nit: `// P10 Vector Insert.`


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:594
+                         [(set v16i8:$vD, (int_ppc_altivec_vinsblx
+                         i64:$rA, i64:$rB))]>;
+  def VINSBRX : VXForm_1<783, (outs vrrc:$vD), (ins g8rc:$rA, g8rc:$rB),
----------------
The indentation of `VINSBLX` and instructions below looks okay to me, but move the `i64:$rA . . .` sections below `(int_ppc_altivec_ . . . `


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82365/new/

https://reviews.llvm.org/D82365