[PATCH] D82365: [Power10] Implement Vector Insert Builtins in LLVM/Clang

[Lei Huang via Phabricator via llvm-commits]

lei added inline comments.


================
Comment at: clang/lib/Headers/altivec.h:16863
+
+static __inline__ vector unsigned long long __ATTRS_o_ai vec_insertl(
+    unsigned long long __a, vector unsigned long long __b, unsigned int __c) {
----------------
`vec_insertl(` should be on the next line. Same as previous definitions.
Same comment for all the def below this one.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:555
                                (int_ppc_altivec_vclrrb v16i8:$vA, i32:$rB))]>;
+  def VINSBVLX :
+    VXForm_1
----------------
Please match the indentation of these new instructions to the ones above and below them.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:560
+     [(set v16i8:$vD, (int_ppc_altivec_vinsbvlx
+     i64:$rA, v16i8:$vB))]>;
+  def VINSBVRX :
----------------
nit: this line should match right under `int_ppc_altivec_vinsbvlx`.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82365/new/

https://reviews.llvm.org/D82365