[PATCH] D82365: [Power10] Implement Vector Insert Builtins in LLVM/Clang

Biplob Mishra via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 23:57:32 PDT 2020


biplmish marked 3 inline comments as done.
biplmish added inline comments.


================
Comment at: clang/lib/Headers/altivec.h:16863
+
+static __inline__ vector unsigned long long __ATTRS_o_ai vec_insertl(
+    unsigned long long __a, vector unsigned long long __b, unsigned int __c) {
----------------
lei wrote:
> `vec_insertl(` should be on the next line. Same as previous definitions.
> Same comment for all the def below this one.
This is based on the clang-format update.  Changes to this gives warnings from clang-format.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82365/new/

https://reviews.llvm.org/D82365





More information about the llvm-commits mailing list