[PATCH] D81801: Remove KillTheDoctor

Sat Jun 13 18:09:36 PDT 2020

Bigcheese added a comment.

The reason `KillTheDoctor` exists is because of test-suite. It compiles and runs programs that do not contain calls to that API, and can do so with non-llvm compilers. I personally don't use it anymore as I don't run test-suite on Windows anymore, but I'm still not aware of any way short of changing registry settings to run test-suite on Windows without hanging other than this.

It's been 10 years, but I believe I tried the solution from https://devblogs.microsoft.com/oldnewthing/20160204-00/?p=92972 , but that didn't stop all modal dialog boxes from popping up.

With that, I'm not totally against removing it if nobody is using it. Just want to be clear that we don't have an alternate solution for what it solves.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81801/new/

https://reviews.llvm.org/D81801