[PATCH] D81801: Remove KillTheDoctor

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur created this revision.
Meinersbur added reviewers: Bigcheese, rnk, abdulras, hans.
Herald added subscribers: Sanitizers, dexonsmith, steven_wu, hiraditya, mgorny.
Herald added projects: Sanitizers, LLVM.

Remove the program "KillTheDoctor". It implemented a workaround for stopping "Dr. Watson" (Name of the error reporting tool in older version of Windows) from launching on regression tests. Win32 has an API for disabling error reporting which is already implemented in `sys::DisableSystemDialogsOnCrash()`, gtest and relevant test cases such as `compiler-rt/test/asan/TestCases/ill.cpp`.

For more details and discussion, see http://lists.llvm.org/pipermail/llvm-dev/2020-June/142099.html

It would be an idea to generally launch programs with the `SEM_NO­GP­FAULT­ERROR­BOX` flag in `llvm-lit` (and maybe `not`), so its is not necessary to insert code in test case programs that are not based on an LLVM tool or gtest. This would by done by passing creationflags=SEM_NO­GP­FAULT­ERROR­BOX to subprocess.Popen in python.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81801

Files:
  compiler-rt/test/CMakeLists.txt
  compiler-rt/test/cfi/anon-namespace.cpp
  compiler-rt/test/cfi/bad-cast.cpp
  compiler-rt/test/cfi/base-derived-destructor.cpp
  compiler-rt/test/cfi/cross-dso/icall/diag.cpp
  compiler-rt/test/cfi/cross-dso/icall/dlopen.cpp
  compiler-rt/test/cfi/cross-dso/icall/icall-from-dso.cpp
  compiler-rt/test/cfi/cross-dso/icall/icall.cpp
  compiler-rt/test/cfi/cross-dso/shadow_is_read_only.cpp
  compiler-rt/test/cfi/cross-dso/simple-fail.cpp
  compiler-rt/test/cfi/icall/bad-signature.c
  compiler-rt/test/cfi/icall/wrong-signature-mixed-lto.c
  compiler-rt/test/cfi/lit.cfg.py
  compiler-rt/test/cfi/mfcall.cpp
  compiler-rt/test/cfi/multiple-inheritance.cpp
  compiler-rt/test/cfi/nvcall.cpp
  compiler-rt/test/cfi/overwrite.cpp
  compiler-rt/test/cfi/sibling.cpp
  compiler-rt/test/cfi/simple-fail.cpp
  compiler-rt/test/cfi/vdtor.cpp
  compiler-rt/test/gwp_asan/double_delete.cpp
  compiler-rt/test/gwp_asan/double_deletea.cpp
  compiler-rt/test/gwp_asan/double_free.cpp
  compiler-rt/test/gwp_asan/heap_buffer_overflow.cpp
  compiler-rt/test/gwp_asan/heap_buffer_underflow.cpp
  compiler-rt/test/gwp_asan/invalid_free_left.cpp
  compiler-rt/test/gwp_asan/invalid_free_right.cpp
  compiler-rt/test/gwp_asan/realloc.cpp
  compiler-rt/test/gwp_asan/use_after_delete.cpp
  compiler-rt/test/gwp_asan/use_after_deletea.cpp
  compiler-rt/test/gwp_asan/use_after_free.cpp
  compiler-rt/test/lit.common.cfg.py
  compiler-rt/test/profile/gcov-__gcov_flush-terminate.c
  compiler-rt/test/ubsan/TestCases/Misc/bounds.cpp
  llvm/CMakeLists.txt
  llvm/utils/KillTheDoctor/CMakeLists.txt
  llvm/utils/KillTheDoctor/KillTheDoctor.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81801.270595.patch
Type: text/x-patch
Size: 62024 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200614/f082256c/attachment.bin>