[PATCH] D81801: Remove KillTheDoctor

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

I found some historic information by @Bigcheese: https://stackoverflow.com/questions/3735456/disable-windows-automated-handling-of-errors-in-subprocesses

According to this, problem was not SEM_NO­GP­FAULT­ERROR­BOX, but Dr. Watson ignoring it for unhandled exceptions (and the dialog box launched by the msvc runtime when an assertion failed and not in a debugger). I think the modern Windows error reporting does not have that issue anymore and the dialog box implementation of assert messagebox can be removed with `_CrtSetReportMode`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81801/new/

https://reviews.llvm.org/D81801