[PATCH] D81389: dwarf::isCPlusPlus fails with user language

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 07:39:37 PDT 2020


probinson added a comment.

FTR, we like to have full context diffs as described here: https://llvm.org/docs/Phabricator.html#phabricator-request-review-web

The code patch looks fine.  However, we want tests for all new features, but the patch introducing `isCPlusPlus` doesn't seem to have included an explicit test, and making you write one seems excessive.  + @dblaikie as he committed that faux pas.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81389/new/

https://reviews.llvm.org/D81389





More information about the llvm-commits mailing list