[PATCH] D81389: dwarf::isCPlusPlus fails with user language

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 07:38:31 PDT 2020


jmorse added reviewers: aprantl, dblaikie, probinson, avl.
jmorse added a comment.

@waj Could you upload the diff with context added (add -U99999 to your diff command). I should have linked you to the docs on uploading reviews sorry, which are here: https://llvm.org/docs/Phabricator.html#phabricator-request-review-web

I've added some DWARFy reviewers. The change seems reasonable to me: we accept any language number in the correct range in DIBuilder::createCompileUnit, so it seems odd to then abort due to illegal state in isCPlusPlus, unless there's some underlying assumption that I'm not familiar with.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81389/new/

https://reviews.llvm.org/D81389





More information about the llvm-commits mailing list