[PATCH] D81389: dwarf::isCPlusPlus fails with user language
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 8 10:30:16 PDT 2020
aprantl added a comment.
Without the context it's difficult to tell, but I'd image that you might be able to add a tiny unit test for this. The code change itself LGTM in the sense of that it is strictly better than crashing, however, I wonder what that means if someone adds a custom C++-based dialect in the user range. I guess they'll need to update this function then.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81389/new/
https://reviews.llvm.org/D81389
More information about the llvm-commits
mailing list