[PATCH] D81097: [llvm-objcopy] Reorder --dump-section before --remove-section for ELF. Fixes PR44283

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp:622
+  // compatibility with GNU objcopy.
+  for (const auto &Flag : Config.DumpSection) {
+    StringRef SectionName;
----------------
alexshap wrote:
> nit: 
>    for (StringRef Flag : Config.DumpSection) 
> 
> StringRef is usually passed by value (it's essentially just a pointer + size)
and the same comment applies to https://reviews.llvm.org/D81123


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81097/new/

https://reviews.llvm.org/D81097