[PATCH] D81097: [llvm-objcopy] Reorder --dump-section before --remove-section for ELF. Fixes PR44283
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 3 19:17:40 PDT 2020
alexshap added inline comments.
================
Comment at: llvm/test/tools/llvm-objcopy/ELF/dump-before-add-remove.test:11
+# RUN: not llvm-objcopy --dump-section .test3=%t3.txt --add-section .test3=%t1.txt %t %t4 2>&1 | \
+# RUN: FileCheck %s --check-prefix=NODUMP -DINPUT=%t -DSECTION=.test3
+
----------------
nit: it looks like it's the only place where these macros (INPUT, SECTION) are used. In this case we don't really need them, simply use the corresponding values directly (on the line 37)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81097/new/
https://reviews.llvm.org/D81097
More information about the llvm-commits
mailing list