[PATCH] D81097: [llvm-objcopy] Reorder --dump-section before --remove-section for ELF. Fixes PR44283
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 3 18:45:38 PDT 2020
alexshap added inline comments.
================
Comment at: llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp:622
+ // compatibility with GNU objcopy.
+ for (const auto &Flag : Config.DumpSection) {
+ StringRef SectionName;
----------------
nit:
for (StringRef Flag : Config.DumpSection)
StringRef is usually passed by value (it's essentially just a pointer + size)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81097/new/
https://reviews.llvm.org/D81097
More information about the llvm-commits
mailing list