[PATCH] D80665: [MachineLICM] Assert that locations from debug insts are not lost

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 27 15:50:06 PDT 2020


vsk added a comment.

In D80665#2058533 <https://reviews.llvm.org/D80665#2058533>, @davide wrote:

> Do you think it's worth writing a verifier check to make sure that `DBG_VALUE`(s) when hoisted have always a location -- otherwise the MIR is considered illformed? I can do that, but I would like to have your opinion on it.


That's a good point. I went ahead and took a stab at this: https://reviews.llvm.org/D80670.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80665/new/

https://reviews.llvm.org/D80665





More information about the llvm-commits mailing list