[PATCH] D80665: [MachineLICM] Assert that locations from debug insts are not lost

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 27 14:43:24 PDT 2020


davide added a comment.

As we discussed offline, I think the assertion makes sense, so LGTM. It's good to catch violations while we decide what to do with hoisting (what are the semantics et similia).
Do you think it's worth writing a verifier check to make sure that `DBG_VALUE`(s) when hoisted have always a location -- otherwise the MIR is considered illformed? I can do that, but I would like to have your opinion on it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80665/new/

https://reviews.llvm.org/D80665





More information about the llvm-commits mailing list