[PATCH] D80665: [MachineLICM] Assert that locations from debug insts are not lost

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 10:56:50 PDT 2020


jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

LGTM -- I'd suggest that the assertion messages could become something like "Shouldn't be hoisting debug instructions" or similar. IMO, as well as the matter of dropping DebugLocs, debug instructions should (almost?) never appears as a candidate to be moved around like another instruction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80665/new/

https://reviews.llvm.org/D80665





More information about the llvm-commits mailing list