[PATCH] D79489: [mlir][Linalg] NFC - Refactor and simplify Promotion

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.
Herald added a subscriber: jurahul.


================
Comment at: mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h:96
+  LinalgPromotionOptions &setOperandsToPromote(ArrayRef<int64_t> operands) {
+    operandsToPromote = DenseSet<unsigned>();
+    operandsToPromote->insert(operands.begin(), operands.end());
----------------
`operandsToPromote = DenseSet<unsigned>(operands.begin(), operands.end())`?


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp:75
+        subViews.insert(sv);
+    }
+  } else {
----------------
nit: Can we early exit here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79489/new/

https://reviews.llvm.org/D79489