[PATCH] D79455: [mlir][StandardToLLVM] Add support for lowering FPToSIOp to LLVM.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 27 12:29:47 PDT 2020


rriddle added inline comments.
Herald added a subscriber: jurahul.


================
Comment at: mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp:2307
 
+struct FPToSILowering
+    : public OneToOneConvertToLLVMPattern<FPToSIOp, LLVM::FPToSIOp> {
----------------
Can we start using `using` directives for these instead?

`using FPToSILowering = OneToOneConvertToLLVMPattern<FPToSIOp, LLVM::FPToSIOp>;`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79455/new/

https://reviews.llvm.org/D79455





More information about the llvm-commits mailing list