[PATCH] D79246: [mlir][vector] set alignment when lowering transfer_read and transfer_write.
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 27 12:29:48 PDT 2020
rriddle added inline comments.
Herald added a subscriber: jurahul.
================
Comment at: mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp:755
+LogicalResult getLLVMTypeAndAlignment(LLVMTypeConverter &typeConverter,
+ Type type, LLVM::LLVMType &llvmType,
----------------
nit: Static functions should be marked `static` and in the top-level namespace, i.e., not within an anonymous namespace.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79246/new/
https://reviews.llvm.org/D79246
More information about the llvm-commits
mailing list