[PATCH] D79671: [MsgPack] MsgPackDocument::readFromBlob now merges

[Scott Linder via Phabricator via llvm-commits]

scott.linder accepted this revision.
scott.linder added a comment.
This revision is now accepted and ready to land.

LGTM, thank you for bearing with us taking a while to review. I left a small request but feel free to commit without updating the review.



================
Comment at: llvm/include/llvm/BinaryFormat/MsgPackDocument.h:43
+  // one more than the last msgpack::Type enum value in MsgPackReader.h.
+  static constexpr Type EmptyKind = Type(10);
+
----------------
Small nit, could this be moved into the enum in `MsgPackReader.h` with a similar comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79671/new/

https://reviews.llvm.org/D79671