[PATCH] D79671: [MsgPack] MsgPackDocument::readFromBlob now merges

Tim Renouf via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 21 12:59:37 PDT 2020


tpr marked 2 inline comments as done.
tpr added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/MsgPackDocument.h:43
+  // one more than the last msgpack::Type enum value in MsgPackReader.h.
+  static constexpr Type EmptyKind = Type(10);
+
----------------
scott.linder wrote:
> Small nit, could this be moved into the enum in `MsgPackReader.h` with a similar comment?
Will do, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79671/new/

https://reviews.llvm.org/D79671





More information about the llvm-commits mailing list