[PATCH] D79671: [MsgPack] MsgPackDocument::readFromBlob now merges

[Scott Linder via Phabricator via llvm-commits]

scott.linder added a comment.

In D79671#2041363 <https://reviews.llvm.org/D79671#2041363>, @tpr wrote:

> With the nil/empty change, there is a change in behavior in that doing a map lookup "map[key]" with a key not previously in the map creates a new map entry that is empty rather than nil. That is more correct, but I have just discovered some code in LLPC relying on the old behavior. I can fix the LLPC code, but is the change in behavior going to cause any HSA problems?


Sorry, I didn't notice this right away. Thank you for checking, I don't believe we have anywhere that relies on the old behavior, we don't really have any cases where a nil node is valid in HSA metadata.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79671/new/

https://reviews.llvm.org/D79671