[PATCH] D79635: [RISCV] Split the pseudo instruction splitting pass

[Luís Marques via Phabricator via llvm-commits]

luismarques marked an inline comment as done.
luismarques added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetMachine.cpp:171
 
+void RISCVPassConfig::addPreSched2() { addPass(createRISCVExpandPseudoPass()); }
+
----------------
jrtc27 wrote:
> Is this what clang-format enforces? I don't like this style, it makes the diffs needlessly messy when someone adds another pass here.
It was what clang-format asked for, yes. But I suspect it only did so because it saw surrounding functions doing the same thing, and it went for consistency. I'm also not a big fan, but if we want to change that it probably should be a separate patch that changes them all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79635/new/

https://reviews.llvm.org/D79635