[PATCH] D79096: [SelectionDAG] Unify scalarizeVectorLoad and VectorLegalizer::ExpandLoad

LemonBoy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 15:06:38 PDT 2020


LemonBoy added a comment.

> Its ok that they are garbage. Type legalization inserted the anyextend which allowed them to be garbage. Type legalization in the caller that consumes the vector result is responsible for clearing them if it needs to.

I see, the hidden contract with the caller is the piece I was missing.
Nonetheless leaving the `AND` seems to help some backends produce slightly tighter code, updating the test suite with that change shows a net increase of ~200 lines. I have no strong opinion about the redundant `AND`, I can easily update the patch and completely drop it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79096/new/

https://reviews.llvm.org/D79096





More information about the llvm-commits mailing list