[PATCH] D78364: [MC][Bugfix] Remove redundant parameter for relaxInstruction
Jessica Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 19 16:01:40 PDT 2020
jrtc27 added inline comments.
================
Comment at: llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp:353
Res.addOperand(MCOperand::createReg(0));
+ Inst = Res;
return;
----------------
MaskRay wrote:
> `Inst = std::move(Res);`
Also please make `Res` scoped to the `if`. I also note that it would be nice for the code to use `ARMCC::AL` rather than the hard-coded 14, but that's unrelated to this patch...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78364/new/
https://reviews.llvm.org/D78364
More information about the llvm-commits
mailing list