[PATCH] D78364: [MC][Bugfix] Remove redundant parameter for relaxInstruction

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Seems reasonable. I've only got some nits about using move assignments.



================
Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUAsmBackend.cpp:63
   Res.addOperand(Inst.getOperand(0));
+  Inst = Res;
   return;
----------------
`Inst = std::move(Res);`


================
Comment at: llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp:353
     Res.addOperand(MCOperand::createReg(0));
+    Inst = Res;
     return;
----------------
`Inst = std::move(Res);`


================
Comment at: llvm/lib/Target/Hexagon/MCTargetDesc/HexagonAsmBackend.cpp:684
+
+    Inst = Res;
     (void)Update;
----------------
`Inst = std::move(Res);`


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp:176
   }
+  Inst = Res;
 }
----------------
`Inst = std::move(Res);`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78364/new/

https://reviews.llvm.org/D78364