[PATCH] D78266: [mlir][Linalg] Drop function attribute from generic ops.

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache created this revision.
Herald added subscribers: llvm-commits, frgossen, grosul1, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a project: LLVM.
nicolasvasilache added reviewers: jpienaar, mehdi_amini, ftynse, mravishankar, silvas.

The function attribute in generic ops is not paying for itself.
A region is the more standardized way of specifying a custom computation.
If needed this region can call a function directly.
This is deemed more natural than managing a dedicated function attribute.

This also simplifies named ops generation by trimming unnecessary complexity.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78266

Files:
  mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
  mlir/include/mlir/Dialect/Utils/StructuredOpsUtils.h
  mlir/lib/Dialect/Linalg/EDSC/Builders.cpp
  mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
  mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp
  mlir/lib/Dialect/Linalg/Transforms/LinalgToLoops.cpp
  mlir/test/Dialect/Linalg/invalid.mlir
  mlir/test/Dialect/Linalg/loops.mlir
  mlir/test/Dialect/Linalg/roundtrip.mlir
  mlir/test/Dialect/Linalg/transform-patterns.mlir
  mlir/test/lib/DeclarativeTransforms/TestLinalgTransformPatterns.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78266.257940.patch
Type: text/x-patch
Size: 52903 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200416/acdf950c/attachment.bin>