[PATCH] D78266: [mlir][Linalg] Drop function attribute from generic ops.

[Mahesh Ravishankar via Phabricator via llvm-commits]

mravishankar accepted this revision.
mravishankar added a comment.
This revision is now accepted and ready to land.

This looks good to me. Thanks for taking care of this. The function attribute on generic/indexed generic doesnt seem to provide value.



================
Comment at: mlir/test/Dialect/Linalg/invalid.mlir:57
 
 func @generic_at_least_2_operands(%arg0: memref<f32>) {
+  // expected-error @+6 {{expected '{' to begin a region}}
----------------
Nit: Change function name to @generic_no_region


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78266/new/

https://reviews.llvm.org/D78266