[PATCH] D78090: [mlir] NFC: Fix trivial typo under Dialects
Kazuaki Ishizaki via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 14 02:37:08 PDT 2020
kiszk marked an inline comment as done.
kiszk added inline comments.
================
Comment at: mlir/docs/Dialects/SPIR-V.md:1012
-[Standard index Type][MlirIndexType] need special handling since they are not
directly supported in SPIR-V. Currently the `index` type is converted to `i32`.
----------------
ftynse wrote:
> There is only one type `index` type, so changing it to plural here is not correct.
I agree. In that case, do we update `standard vector types` and `Standard memref types` based on the comment?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78090/new/
https://reviews.llvm.org/D78090
More information about the llvm-commits
mailing list