[PATCH] D78090: [mlir] NFC: Fix trivial typo under Dialects

[Kazuaki Ishizaki via Phabricator via llvm-commits]

kiszk updated this revision to Diff 257244.
kiszk added a comment.

address review comments


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78090/new/

https://reviews.llvm.org/D78090

Files:
  mlir/docs/Dialects/GPU.md
  mlir/docs/Dialects/LLVM.md
  mlir/docs/Dialects/SPIR-V.md
  mlir/docs/Dialects/Vector.md


Index: mlir/docs/Dialects/Vector.md
===================================================================
--- mlir/docs/Dialects/Vector.md
+++ mlir/docs/Dialects/Vector.md
@@ -44,7 +44,7 @@
 intrinsics. This is referred to as the `LLVM` level.
 2. Set of machine-specific operations and types that are built to translate
 almost 1-1 with the HW ISA. This is referred to as the Hardware Vector level;
-a.k.a `HWV`. For instance, we have (a) an `NVVM` dialect (for `CUDA`) with
+a.k.a `HWV`. For instance, we have (a) the `NVVM` dialect (for `CUDA`) with
 tensor core ops, (b) accelerator-specific dialects (internal), a potential
 (future) `CPU` dialect to capture `LLVM` intrinsics more closely and other
 dialects for specific hardware. Ideally this should be auto-generated as much
Index: mlir/docs/Dialects/SPIR-V.md
===================================================================
--- mlir/docs/Dialects/SPIR-V.md
+++ mlir/docs/Dialects/SPIR-V.md
@@ -172,7 +172,7 @@
 *   Normal constants are not placed in `spv.module`'s region; they are localized
     into functions. This is to make functions in the SPIR-V dialect to be
     isolated and explicit capturing. Constants are cheap to duplicate given
-    attributes are unique in `MLIRContext`.
+    attributes are made unique in `MLIRContext`.
 
 #### Adopt symbol-based global variables and specialization constant
 
@@ -239,7 +239,7 @@
 For decorations on type result ids, notice that practically, only result ids
 generated from composite types (e.g., `OpTypeArray`, `OpTypeStruct`) need to be
 decorated for memory layouting purpose (e.g., `ArrayStride`, `Offset`, etc.);
-scalar/vector types are required to be unique in SPIR-V. Therefore, we can just
+scalar/vector types are required to be uniqued in SPIR-V. Therefore, we can just
 encode them directly in the dialect-specific type.
 
 ## Types
@@ -1009,7 +1009,7 @@
 it will be unconditionally converted to 32-bit. This should be switched to
 properly emulating non-32-bit scalar types.)
 
-[Standard index types][MlirIndexType] need special handling since they are not
+[Standard index type][MlirIndexType] need special handling since they are not
 directly supported in SPIR-V. Currently the `index` type is converted to `i32`.
 
 (TODO: Allow for configuring the integer width to use for `index` types in the
Index: mlir/docs/Dialects/LLVM.md
===================================================================
--- mlir/docs/Dialects/LLVM.md
+++ mlir/docs/Dialects/LLVM.md
@@ -395,7 +395,7 @@
 Only one of the initializer attribute or initializer region may be provided.
 
 `llvm.mlir.global` must appear at top-level of the enclosing module. It uses an
- at -identifier for its value, which will be unique by the module with respect to
+ at -identifier for its value, which will be uniqued by the module with respect to
 other @-identifiers in it.
 
 Examples:
Index: mlir/docs/Dialects/GPU.md
===================================================================
--- mlir/docs/Dialects/GPU.md
+++ mlir/docs/Dialects/GPU.md
@@ -23,7 +23,7 @@
 workgroup memory into other functions, provided they expect the correct memory
 space.
 
-The buffers are considered to live throughout the execution of the GPU function
+The buffers are considered live throughout the execution of the GPU function
 body. The absence of memory attribution syntax means that the function does not
 require special buffers. Rationale: although the underlying models declare
 memory buffers at the module level, we chose to do it at the function level to


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78090.257244.patch
Type: text/x-patch
Size: 3540 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200414/a493b7e5/attachment.bin>