[PATCH] D78090: [mlir] NFC: Fix trivial typo under Dialects

[Kazuaki Ishizaki via Phabricator via llvm-commits]

kiszk marked an inline comment as done.
kiszk added inline comments.


================
Comment at: mlir/docs/Dialects/GPU.md:26
 
-The buffers are considered live throughout the execution of the GPU function
 body. The absence of memory attribution syntax means that the function does not
----------------
ftynse wrote:
> I don't think the fix here is correct. You could rephrase it as "are considered to _be_ live" (or keep as is, which is equivalent), but not as "to live".
Thank you for your comment.


================
Comment at: mlir/docs/Dialects/LLVM.md:398
 `llvm.mlir.global` must appear at top-level of the enclosing module. It uses an
- at -identifier for its value, which will be uniqued by the module with respect to
 other @-identifiers in it.
----------------
ftynse wrote:
> We did intend to use "unique" as a verb, and do so repeatedly in multiple places. We use "to unique" to refer to the process of making something unique. You'll notice that "will be unique by the module" does not sound correct grammatically, similarly to "will be fix by the module" for example.
Thank you for your clarification. I understand the intention I thought that "unique" is an adjective.
I will revert them.


================
Comment at: mlir/docs/Dialects/Vector.md:47
 almost 1-1 with the HW ISA. This is referred to as the Hardware Vector level;
-a.k.a `HWV`. For instance, we have (a) a `NVVM` dialect (for `CUDA`) with
 tensor core ops, (b) accelerator-specific dialects (internal), a potential
----------------
ftynse wrote:
> I'd rather make it "the `NVVM`" dialect :)
I tried to keep the original usage. But, I totally agree with you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78090/new/

https://reviews.llvm.org/D78090