[PATCH] D78090: [mlir] NFC: Fix trivial typo under Dialects

[Alex Zinenko via Phabricator via llvm-commits]

ftynse requested changes to this revision.
ftynse added a comment.
This revision now requires changes to proceed.

Thanks!

While making spelling and wording changes, please make sure the original meaning of the text is maintainted.



================
Comment at: mlir/docs/Dialects/GPU.md:26
 
-The buffers are considered live throughout the execution of the GPU function
 body. The absence of memory attribution syntax means that the function does not
----------------
I don't think the fix here is correct. You could rephrase it as "are considered to _be_ live" (or keep as is, which is equivalent), but not as "to live".


================
Comment at: mlir/docs/Dialects/LLVM.md:398
 `llvm.mlir.global` must appear at top-level of the enclosing module. It uses an
- at -identifier for its value, which will be uniqued by the module with respect to
 other @-identifiers in it.
----------------
We did intend to use "unique" as a verb, and do so repeatedly in multiple places. We use "to unique" to refer to the process of making something unique. You'll notice that "will be unique by the module" does not sound correct grammatically, similarly to "will be fix by the module" for example.


================
Comment at: mlir/docs/Dialects/SPIR-V.md:175
     isolated and explicit capturing. Constants are cheap to duplicate given
-    attributes are uniqued in `MLIRContext`.
 
----------------
This sounds correct, but no longer conveys the same meaning. The original meaning is that attributes are _made_ unique by the MLIR context.


================
Comment at: mlir/docs/Dialects/SPIR-V.md:242
 decorated for memory layouting purpose (e.g., `ArrayStride`, `Offset`, etc.);
-scalar/vector types are required to be uniqued in SPIR-V. Therefore, we can just
 encode them directly in the dialect-specific type.
----------------
Same as above


================
Comment at: mlir/docs/Dialects/SPIR-V.md:1012
 
-[Standard index Type][MlirIndexType] need special handling since they are not
 directly supported in SPIR-V. Currently the `index` type is converted to `i32`.
----------------
There is only one type `index` type, so changing it to plural here is not correct.


================
Comment at: mlir/docs/Dialects/Vector.md:47
 almost 1-1 with the HW ISA. This is referred to as the Hardware Vector level;
-a.k.a `HWV`. For instance, we have (a) a `NVVM` dialect (for `CUDA`) with
 tensor core ops, (b) accelerator-specific dialects (internal), a potential
----------------
I'd rather make it "the `NVVM`" dialect :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78090/new/

https://reviews.llvm.org/D78090