[PATCH] D39111: Extensible LLVM RTTI

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 17:56:50 PDT 2020


lhames added a comment.

Cool. I'll get this tidied up and clarify the rules about the ID member.

Did you have any thoughts on switching to type_traits for the ID? On the one hand it's safer since you couldn't accidentally fall through to your parent's ID, on the other hand it's more complex boilerplate: an extern specialization rather than a static id.

- Lang.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D39111/new/

https://reviews.llvm.org/D39111





More information about the llvm-commits mailing list