[PATCH] D39111: Extensible LLVM RTTI

[David Blaikie via Phabricator via llvm-commits]

dblaikie requested changes to this revision.
dblaikie added a comment.
This revision now requires changes to proceed.

Yeah, I'm not sure a template specialization solution would be a huge improvement (& maybe even more likely people would define the constants in headers?). Hmm - could you use a /function/ pointer instead? Would that work I guess it'd have the same problem (if it's an inline function I guess Microsoft doesn't use a single address/value across dynamic libraries).

I don't expect this'll be used widely to the point where it becomes a real lot of gotchas, but probably good if you setup some Herald rules to watch for uses of this if possible to keep an eye on new uses.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D39111/new/

https://reviews.llvm.org/D39111