[llvm] f3d3cec - [InstCombine] Avoid a call to deprecated version of CreateCall.

[Craig Topper via llvm-commits]

Author: Craig Topper
Date: 2020-04-08T17:41:16-07:00
New Revision: f3d3cec648202cde1f34b766b4d8fe147f68f1fe

URL: https://github.com/llvm/llvm-project/commit/f3d3cec648202cde1f34b766b4d8fe147f68f1fe
DIFF: https://github.com/llvm/llvm-project/commit/f3d3cec648202cde1f34b766b4d8fe147f68f1fe.diff

LOG: [InstCombine] Avoid a call to deprecated version of CreateCall.

Passing a Value * to CreateCall has to call getPointerElementType
to find the type of the pointer.

In this case we can rely on the fact that Intrinsic::getDeclaration
returns a Function * and use that version of CreateCall.

Added: 
    

Modified: 
    llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp b/llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
index 26837a131417..377d0be6a2b1 100644
--- a/llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
@@ -2324,8 +2324,8 @@ Instruction *InstCombiner::visitCallInst(CallInst &CI) {
     if (match(II->getArgOperand(0), m_OneUse(m_FPExt(m_Value(ExtSrc0)))) &&
         match(II->getArgOperand(1), m_OneUse(m_FPExt(m_Value(ExtSrc1)))) &&
         ExtSrc0->getType() == ExtSrc1->getType()) {
-      Value *F = Intrinsic::getDeclaration(II->getModule(), II->getIntrinsicID(),
-                                           { ExtSrc0->getType() });
+      Function *F = Intrinsic::getDeclaration(
+          II->getModule(), II->getIntrinsicID(), {ExtSrc0->getType()});
       CallInst *NewCall = Builder.CreateCall(F, { ExtSrc0, ExtSrc1 });
       NewCall->copyFastMathFlags(II);
       NewCall->takeName(II);