[PATCH] D77659: [ELF][test] Add reproduce test for dependent libraries

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: lld/test/ELF/reproduce-deplibs.s:1
+# REQUIRES: x86, shell
+
----------------
ruiu wrote:
> andrewng wrote:
> > MaskRay wrote:
> > > Can you also delete `shell` and check whether harbomaster (pre-merge testing) complains?
> > I can try deleting `shell` but will need to add it back to prevent potential testing issues on Windows related to paths being too long when the reproduce TAR file is extracted. That's the reason why all the reproduce tests that extract the TAR file include `shell`.
> So basically you want to run this test on non-windows machine right?
> 
>   UNSUPPORTED: system-windows
> 
> should express the intention more clearly.
It might be worth a comment too saying WHY it's not supported on Windows, because that restriction isn't obvious at first glance.


================
Comment at: lld/test/ELF/reproduce-deplibs.s:12
+# RUN: ld.lld bar.o -o /dev/null --reproduce repro.tar
+# RUN: tar xf repro.tar
+# RUN: cmp foo.a repro/%:t.dir/foo.a
----------------
Idle musing, feel free to ignore: I wonder whether we really need to check that the archive in the tar file is binary identical to the input one? Would just checking that the file is in the package be sufficient?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77659/new/

https://reviews.llvm.org/D77659