[PATCH] D77659: [ELF][test] Add reproduce test for dependent libraries
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 8 02:07:51 PDT 2020
grimar added inline comments.
================
Comment at: lld/test/ELF/reproduce-deplibs.s:12
+# RUN: ld.lld bar.o -o /dev/null --reproduce repro.tar
+# RUN: tar xf repro.tar
+# RUN: cmp foo.a repro/%:t.dir/foo.a
----------------
jhenderson wrote:
> Idle musing, feel free to ignore: I wonder whether we really need to check that the archive in the tar file is binary identical to the input one? Would just checking that the file is in the package be sufficient?
I also wonder about it.
Our `reproduce-windows.s` has:
```
# RUN: tar tf repro.tar | FileCheck %s
# CHECK: repro/response.txt
# CHECK: repro/{{.*}}/build/foo.o
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77659/new/
https://reviews.llvm.org/D77659
More information about the llvm-commits
mailing list