[PATCH] D77659: [ELF][test] Add reproduce test for dependent libraries

Tue Apr 7 21:46:05 PDT 2020

ruiu added inline comments.

================
Comment at: lld/test/ELF/reproduce-deplibs.s:1
+# REQUIRES: x86, shell
+
----------------
andrewng wrote:
> MaskRay wrote:
> > Can you also delete `shell` and check whether harbomaster (pre-merge testing) complains?
> I can try deleting `shell` but will need to add it back to prevent potential testing issues on Windows related to paths being too long when the reproduce TAR file is extracted. That's the reason why all the reproduce tests that extract the TAR file include `shell`.
So basically you want to run this test on non-windows machine right?

  UNSUPPORTED: system-windows

should express the intention more clearly.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77659/new/

https://reviews.llvm.org/D77659