[PATCH] D77604: [MachineCSE] Don't carry the wrong location when hoisting
Davide Italiano via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 6 18:34:07 PDT 2020
davide marked an inline comment as done.
davide added inline comments.
================
Comment at: llvm/lib/CodeGen/MachineCSE.cpp:839
+ auto EmptyDL = DebugLoc();
+ NewMI.setDebugLoc(EmptyDL);
+
----------------
aprantl wrote:
> Can NewMI be a call?
> If yes, this should be an artificial location instead, or later inlining of the call will cause an IR verifier failure because the inline location is dropped.
I am probably missing the obvious, but this is already MIR. I don't think llvm does any inlining that late in the pipeline.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77604/new/
https://reviews.llvm.org/D77604
More information about the llvm-commits
mailing list